ITP_JAN-2015|sabita-Shrestha|Module-Structuring-and-Testing-Data|week5|sprint1 #260

SabitaShrestha325 · 2025-02-06T21:57:20Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan

I think you probably understand the code.

Describing code can be very challenging initially (even in one's first language). May I suggest using ChatGPT to find out how else code can be described? From time to time you may also learn some useful programming terms from ChatGPT.

cjyuan · 2025-02-12T23:17:28Z

Sprint-1/1-key-exercises/1-count.js


 // Line 1 is a variable declaration, creating the count variable with an initial value of 0
 // Describe what line 3 is doing, in particular focus on what = is doing
+It will evaluate the right hand side argument and add the varaible which is 0+1 = 1


You probably understand what the code does.
However, using the correct terminology is crucial when communicating with other programmers.
May I suggest (with the help of ChatGPT)

Find out how else the code can be described

Look up the terms "expression", "operand", "argument" in programming
?

cjyuan · 2025-02-12T23:23:17Z

Sprint-1/1-key-exercises/2-initials.js


 // https://www.google.com/search?q=get+first+character+of+string+mdn

+//text.charAt(0) means it will print first letter, if  we put 1 than it will print second letter.


A function "returns" (not "prints") a value.

cjyuan · 2025-02-12T23:56:45Z

Sprint-1/1-key-exercises/4-random.js

+
+//When you log several time it will so different value.
+// Math.random gives u the value with floating number like 0.38
+// But Math.floor go around give largest integer ex. if value is 6.95 it will only print 6


Can you shed more details by answer the following questions?

What is the range of values that could be returned by Math.random()?

What is the significance of (maximum - minimum + 1)? What does this expression represent?

What is the significance of ... + minimum?

What is the range of values that could be assigned to num?

To test your understanding, how would you write an expression (without using any variable in the expression) that can yield a random integer between -5 and 5 (including both -5 and 5)?

cjyuan · 2025-02-13T00:03:45Z

Sprint-1/2-mandatory-errors/4.js

+const twelveHourClockTime = "20:53";
+const twentyFourhourClockTime = "08:53";
+console.log(twelveHourClockTime);
+console.log(twentyFourhourClockTime);


Have you also noticed the variable names do not quite match the values assigned to the variable?

cjyuan · 2025-02-13T00:04:42Z

Sprint-1/2-mandatory-errors/3.js

+const cardNumber = "4533787178994213";
 const last4Digits = cardNumber.slice(-4);
-
+console.log(last4Digits);


If you cannot modify the statement const cardNumber = 4533787178994213;
(that is, keep the variable's value unchanged),
how would you modify the code (through type conversion) so that it can still extract the last 4 digits from its value.

cjyuan · 2025-02-13T00:26:17Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+//ans: This is called remainder operator which divide the length of movie 8784 by 60 and place the remaining second which is 24.

 // d) Interpret line 4, what does the expression assigned to totalMinutes mean?
+// ans: It means movie length subtract the remaining seconds and use remainder operator like (8784-24=8760/60) which 146.


You gave a literal translation of the code, but it does not quite explain what the expression (movieLength - remainingSeconds) / 60 does.

Can you describe in terms of whole minute, or use ChatGPT to find out how else the code can be described?

hi, Cjyuan, thank you for your review, I have changed the ans as it was mention. Can you please review.

cjyuan · 2025-02-13T00:34:23Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+// ans: It means movie length subtract the remaining seconds and use remainder operator like (8784-24=8760/60) which 146.

 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// ans I think its define time of the movie length in hour, minute, and second. Better name for this variable will be "timeString".


"time" can ambiguous because it may mean refer to clock time (e.g., 12:30pm), time in seconds, etc.
Can you think of another name for the variable?

cjyuan · 2025-02-13T00:47:45Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+ //In this line, trailing comma is removed from the penceString and substring remove the first line(0) 
+// and one character before the end which is (penceString.length-1) it will left "399"


There is no "trailing comma" in penceString.

.substring() does not actually remove anything from a string; it only returns "part" of a string.

What do you mean by "first line"?

Can you rephrase this description?

cjyuan · 2025-02-13T00:49:48Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+//This line remove the part of the string which is pound and substring from the start(0) to characters before the end paddedPenceNumberString.   
+
+ //const pence = paddedPenceNumberString .substring(paddedPenceNumberString.length - 2) .padEnd(2, "0");
+  //This line of code extracts 2 characters of the string "paddedPenceNumberString" also pads the results to make sure it has 2 characters by adding 0 to format properly.


Which 2 characters are extracted from paddedPenceNumberString?

cjyuan · 2025-02-13T00:50:45Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+//This line make sure the string "penceStringWithoutTrailingP" has 3 character and also adding "0" if necessary and it also penceStringWithoutTrailingP is "99" also padded to "099".
+
+//const pounds = paddedPenceNumberString.substring(0,  paddedPenceNumberString.length - 2);
+//This line remove the part of the string which is pound and substring from the start(0) to characters before the end paddedPenceNumberString.   


What do you mean by "... to characters before the end paddedPenceNumberString"?

cjyuan

Great improvement.

There are still a few descriptions you can improve.

cjyuan · 2025-02-16T03:43:23Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

+// ans: It was SyntaxError: missing ) which is replaceAll(",", "")comma separate argument. 

-// c) Identify all the lines that are variable reassignment statements
+// c) Identify all the lines that are variable assignment statements


Instead of changing the description of the question, your goal is supposed to identify the statements where a variable is re-assigned a value.

let a = 1; // assign a value to variable a a = 2; // re-assign a value to variable a (this is a reassignment statement) a = a + 1; // re-assign a value to variable a (this is also a reassignment statement)

cjyuan · 2025-02-16T03:53:25Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
-// ans: It is value in string which is car price(10,000) and priceAfterOneYear(8,543), also replace and have new string value.
+// ans: The expression Number(carPrice.replaceAll(",", "")) is used to convert a formatted string representation of a number (with commas) into an actual numeric value.
+//Basically Number(carPrice.replaceAll(",","")) remove comma, remove strings and allows number to use mathematical. 


Your description at line 34 is correct.
However, I don't know what you meant by "remove strings" in the statement at line 35.

The two function calls involved in the statement carPrice = Number(carPrice.replaceAll(",", "")) can be broken down into the following code (to demonstrate the order in which the function are called).

const strWithoutComma = carPrice.replaceAll(",", ""); carPrice = Number(strWithoutComma);

cjyuan · 2025-02-16T04:12:43Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+ //In this line, penceString is string with trailing p so to extract p substring is used  and penceString.length - 1,
+ // will be p which will be extract.( penceString.length is 4(399p) penceString.length - 1 will extract end of the length which is p)
+ //so out put will be 399.
+// 


These statements are not very clear.
Extract "p" would suggest taking out "p" and return "p" from the given string.
Can you rephrase it? ChatGPT can probably help.

SabitaShrestha325 · 2025-02-16T19:32:02Z

Great improvement.

There are still a few descriptions you can improve.

Thank you for your review, sorry to bother you again can you please review new changes .

cjyuan · 2025-02-17T08:26:14Z

Looks good. Feel free to mark this as completed.

SabitaShrestha325 · 2025-02-17T09:04:07Z

Looks good. Feel free to mark this as completed.

Thank you.

SabitaShrestha325 added 5 commits February 6, 2025 12:53

key exercises

05d1112

Updated key exercises and fixed mandatory errors

8651354

spelling correction

7e1a21b

mandatory-error

9448fdf

done 3-mandatory-interpret

097d88e

SabitaShrestha325 changed the title ~~Coursework planner sprint 1~~ ITP_JAN-2015|sabita-Shrestha|Module-Structuring-and-Testing-Data|week5|sprint1 Feb 6, 2025

SabitaShrestha325 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2025

cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 12, 2025

cjyuan reviewed Feb 13, 2025

View reviewed changes

SabitaShrestha325 added 6 commits February 15, 2025 16:26

explanation about expression, operand and operator

2a1f2de

change to return

5efd683

expression detail is added

b96d284

fixed camelcase

0bf7256

modify through type conversion

feca213

change ans as advised

9949ef4

SabitaShrestha325 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2025

cjyuan reviewed Feb 16, 2025

View reviewed changes

modify ans

2ec27d1

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2025

SabitaShrestha325 added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Feb 17, 2025

SabitaShrestha325 mentioned this pull request Mar 11, 2025

Module-Structuring-and-Testing-Data #378

Closed

illicitonion closed this Sep 1, 2025


		// https://www.google.com/search?q=get+first+character+of+string+mdn

		//text.charAt(0) means it will print first letter, if we put 1 than it will print second letter.

		//In this line, trailing comma is removed from the penceString and substring remove the first line(0)
		// and one character before the end which is (penceString.length-1) it will left "399"

Uh oh!

ITP_JAN-2015|sabita-Shrestha|Module-Structuring-and-Testing-Data|week5|sprint1 #260

ITP_JAN-2015|sabita-Shrestha|Module-Structuring-and-Testing-Data|week5|sprint1 #260

Uh oh!

Conversation

SabitaShrestha325 commented Feb 6, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SabitaShrestha325 commented Feb 16, 2025

Uh oh!

cjyuan commented Feb 17, 2025

Uh oh!

SabitaShrestha325 commented Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cjyuan left a comment •

edited

Loading